-
Notifications
You must be signed in to change notification settings - Fork 61
upgrade to golangci-lint v2 #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
miparnisari
commented
Jul 28, 2025
- Use golang linter v2
- Move to the module plugin system as recommended by https://golangci-lint.run/plugins/module-plugins
- Fix existing linting issues
Oh, I did not know about https://golangci-lint.run/plugins/module-plugins/ 👀 |
- goworkflows | ||
|
||
linters-settings: | ||
custom: | ||
goworkflows: | ||
path: ./plugin.so | ||
description: go-workflows | ||
original-url: github.com/cschleiden/go-workflows/analyzer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why you would use your own linter in your own project 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repo does contain workflows, like all the different samples and I want to run the linter on those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, ok. I can bring it back. Or maybe we can write a unit test that runs the analyzer programmatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any blockers to running this like it used to with the modules approach? I liked that because it made it easy to dogfood when working on samples and to see how it felt
e3e3227
to
0150252
Compare
Thank for the changes! 🙇 Took them over as part of #433 and a few follow up PRs. |